Convert Middleware and Agent.Host packages to source packages #51335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmat
force-pushed
the
HRSourcePackages
branch
from
1a41af8 to
ffa957e
Compare
DustinCampbell
approved these changes
Oct 17, 2025
| } | ||
|
|
||
| [DllImport("kernel32.dll", SetLastError = true)] | ||
| static extern bool SetConsoleCtrlHandler(Delegate? handler, bool add); |
There was a problem hiding this comment.
❤️🔥 I had no idea that a P/Invoke could be a local function.
mthalman
added a commit
to dkurepa/dotnet
that referenced
this pull request
Oct 23, 2025
This was incorrectly removed from dotnet/sdk#51335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of consuming
Microsoft.DotNet.HotReload.Web.MiddlewareandMicrosoft.Extensions.DotNetDeltaApplierbinaries in dotnet/project-system we will build the binaries from source packages.This allows us to avoid having to insert the final SDK GA build of these packages to VS at the last moment before shipping. The process of doing so is non-trivial.
See dotnet/project-system#9822