refactor(docs): improve wording, fix section #1342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirainen
previously requested changes
Nov 11, 2025
This comment has been minimized.
This comment has been minimized.
cmouse
reviewed
Nov 15, 2025
This comment has been minimized.
This comment has been minimized.
Contributor
|
can you squash the fix: commits? |
Contributor
Author
|
sure. I usually don't bother with squashing because I do that in my prejects upon merge. give nme a sec. |
Contributor
Author
|
done |
Contributor
Author
|
I squashed all commits, since they belong to the PR. e.g. without adding the words to the spelling excludes, the CI fails. |
I've changed the wording and reorganized the text a bit. There was also a formatting bug in the md5-crypt section.
cmouse
approved these changes
Nov 15, 2025
Contributor
Author
|
How can we backport this to 2.4.x? Currently it only shows up in the main documentation https://doc.dovecot.org/main/core/config/auth/schemes.html |
Contributor
|
We usually dont. Itll go out on 2.4.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed the wording and reorganized the text a bit.
There was also a formatting bug in the md5-crypt section.