Skip to content

fix multi ticker download when some tickers failed #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix multi ticker download when some tickers failed #319

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a484350
dev
ericwbzhang Jan 11, 2025
6b029e3
dev
ericwbzhang Jan 11, 2025
dc55e37
fix output formatted which mix the results when calling multiple tickers
ericwbzhang Jan 11, 2025
87549e4
Merge branch 'master' into master_fix_stage
ericwbzhang May 22, 2025
f90f802
Update .gitignore
ericwbzhang May 22, 2025
cce6412
edit
ericwbzhang May 22, 2025
af40b45
edit
ericwbzhang May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions yahooquery/ticker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ def _quote_summary_dataframe(self, module, **kwargs):

def _to_dataframe(self, data, **kwargs):
if not self.formatted:
dataframes = []
dataframes = {}
for symbol in self.symbols:
try:
final_data = (
Expand All @@ -136,14 +136,14 @@ def _to_dataframe(self, data, **kwargs):
df.columns = [symbol]
else:
df = pd.DataFrame(final_data)
dataframes.append(df)
dataframes[symbol]=df
try:
if kwargs.get("from_dict", False):
df = pd.concat(dataframes, axis=1)
df = pd.concat(dataframes.values(), axis=1)
else:
df = pd.concat(
dataframes,
keys=self.symbols,
dataframes.values(),
keys= dataframes.keys(),
names=["symbol", "row"],
sort=False,
)
Expand Down