C++17 filesystem and chrono replacements #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Alex, would you mind signing your commit and reopening this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReleaseNote
Compatibility (major, minor, patch, build): 2.15.0.1
Jira ticket: N/A
Release Notes Comment: N/A
Special Notes: N/A
Look or Scene Setup Change: No?
Reviewers
@jlanz
Pull request comments
This is replacing the posix style of filesystem (basename/dirname) and time (gettimeofday/usleep). It'll need another pair of eyes on it just to make sure there's no mistakes.
I've also got 2 prior commits https://github.com/mnraker/scene_rdl2/tree/build_fixes that are not related to this, but are left in here as I needed them to successfully build for Linux (Rocky 8.10). Let me know and I can remove these or keep them in in this PR.
Rats test images
N/A
Documentation (link)
Unit Test Reminder
Probably a unit-test that deals with DSOs as they would be the most impacted by the filesystem change.