program: auto transfer to cross margin account #1939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crispheaney
changed the base branch from
master
to
crispheaney/isolated-position
LukasDeco
reviewed
Oct 6, 2025
| .get_isolated_token_amount(&spot_market)?; | ||
|
|
||
| // i64::MIN is used to transfer the entire isolated position deposit | ||
| let amount = if amount == i64::MIN { |
There was a problem hiding this comment.
@crispheaney for my understanding on the client-side, does this mean we would pass in like -9223372036854775808? For the instruction?
There was a problem hiding this comment.
can do this from ui yes but not required for settle pnl ix since program does it automatically
LukasDeco
reviewed
Oct 6, 2025
|
|
||
| pub fn can_transfer_isolated_position_deposit(&self) -> bool { | ||
| !self.is_open_position() | ||
| && !self.has_open_order() |
There was a problem hiding this comment.
does this mean if user wanted to transfer but had an open order we would probably want to cancel that or show them an error saying you can't transfer because of this open order?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.