Better gitignore for data directory #223
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exclude everything except git and DVC files
Rely on .gitignore in data directory
|
Lgtm. |
jayqi
requested changes
Mar 1, 2025
| !.gitkeep | ||
|
|
||
| # Include DVC files | ||
| !*.dvc |
There was a problem hiding this comment.
I'm not sure I like putting a .gitignore inside data/. I think it's better to keep these rules in the repo-root-level .gitignore and not mix this into the data directory. This is going to end up getting caught up syncing to the cloud, etc.
Comment on lines
+1
to
+6
| # Ignore all files in all sub-directories by default | ||
| # but not the sub-directories themselves | ||
| # and not files in this directory | ||
| **/* | ||
| !**/ | ||
| !/* |
There was a problem hiding this comment.
Git only tracks files and not directories, so there's no point in trying to have an include rule for directories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data files are still git-ignored by default, but some files, like .gitkeep, .gitignore and *.dvc, should not be ignored by default.
Note that this doesn't required git or DVC but it does improve support for them.