Skip to content

Conversation

@baldwindc
Copy link

Proposed MR for issue #248.

The feedback messages in feedback.coffee are not consistent with regards to punctuation. Some sentences are ended with a period, while others have no ending punctuation mark. This causes inconsistencies with implementing libraries such as https://github.com/antoantonyk/password-strength-meter.

image

@worc
Copy link

worc commented Mar 21, 2019

i think the intent is supposed to be the other way around. no full-stops at the end of feedback is more flexible.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants