Fixes wrong parse exception type being caught by TranquilityEventWriter #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avro extensions from the Druid codebase throw a ParseException from the io.druid.java.util.common.parsers package, the Tranquility code is not catching this as it is expecting the ParseException to be from the com.metamx.common.parsers package. This means that broken messages will halt processing regardless of the reportParseExceptions setting as the exception goes uncaught. Fixed this to use the ParseException from io.druid.java.util.common.parsers package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avro extensions from the Druid codebase throw a ParseException
from the io.druid.java.util.common.parsers package, the Tranquility
code is not catching this as it is expecting the ParseException to
be from the com.metamx.common.parsers package.
This means that broken messages will halt processing regardless of the
reportParseExceptions setting as the exception goes uncaught.
Fixed this to use the ParseException from io.druid.java.util.common.parsers
package