fix: update README.md #53
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsaltares
reviewed
Feb 23, 2023
| ### `regex` | ||
|
|
||
| Boolean indicating if `file` is to be interpreted as regular expression. Defaults to `false`. | ||
| Boolean indicating if `true` is to be interpreted as regular expression. Defaults to `false`. |
There was a problem hiding this comment.
The current README is correct though. This option controls wether the file parameter should be interpreted as a regex or a literal file name.
Perhaps the documentation could be a bit clearer.
There was a problem hiding this comment.
Hello @dsaltares,
Thanks for the explanation. So if the user wants to use the regular expression functionality for a file (e.g. my-file-.*.zip instead of my-file-4.0.1.zip) should the regex parameter be true or false?
I was under the assumption that it should be true for regular expression behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.