Skip to content

Commit 0677ac1

Browse files
committed
Add code_quality section, both to CI and Makefile
1 parent 64f3bfa commit 0677ac1

File tree

2 files changed

+29
-0
lines changed

2 files changed

+29
-0
lines changed

.github/workflows/MainDistributionPipeline.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,3 +33,12 @@ jobs:
3333
ci_tools_version: main
3434
deploy_latest: ${{ startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/main' }}
3535
exclude_archs: 'wasm_mvp;wasm_eh;wasm_threads'
36+
37+
code-quality:
38+
name: Code Quality
39+
uses: duckdb/extension-ci-tools/.github/workflows/_extension_code_quality.yml@main
40+
with:
41+
extension_name: httpfs
42+
duckdb_version: v1.3-ossivalis
43+
ci_tools_version: main
44+
extra_toolchains: 'python3'

Makefile

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,23 @@ CORE_EXTENSIONS=''
88

99
# Include the Makefile from extension-ci-tools
1010
include extension-ci-tools/makefiles/duckdb_extension.Makefile
11+
12+
#### Misc
13+
format-check:
14+
python3 duckdb/scripts/format.py --all --check --directories extension/httpfs test
15+
16+
format:
17+
python3 duckdb/scripts/format.py --all --fix --noconfirm --directories extension/httpfs test
18+
19+
format-fix:
20+
python3 duckdb/scripts/format.py --all --fix --noconfirm --directories extension/httpfs test
21+
22+
format-main:
23+
python3 duckdb/scripts/format.py main --fix --noconfirm --directories extension/httpfs test
24+
25+
tidy-check:
26+
mkdir -p ./build/tidy
27+
cmake $(GENERATOR) $(BUILD_FLAGS) $(EXT_DEBUG_FLAGS) -DDISABLE_UNITY=1 -DCLANG_TIDY=1 -S $(DUCKDB_SRCDIR) -B build/tidy
28+
cp duckdb/.clang-tidy build/tidy/.clang-tidy
29+
cd build/tidy && python3 ../../duckdb/scripts/run-clang-tidy.py '$(PROJ_DIR)extension/httpfs/' -header-filter '$(PROJ_DIR)extension/httpfs/' -quiet ${TIDY_THREAD_PARAMETER} ${TIDY_BINARY_PARAMETER} ${TIDY_PERFORM_CHECKS}
30+

0 commit comments

Comments
 (0)