Skip to content

[Dev] Add py::is_operator() where appropriate for the DuckDBPyExpression interface #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 15, 2025
Merged

[Dev] Add py::is_operator() where appropriate for the DuckDBPyExpression interface #44

merged 2 commits into from
Sep 15, 2025

Conversation

Tishj
Copy link
Collaborator

@Tishj Tishj commented Sep 10, 2025

See https://pybind11.readthedocs.io/en/stable/advanced/classes.html#operator-overloading

This makes it play nicer with the fallbacks that python provides for operator methods

evertlammerts
evertlammerts approved these changes Sep 15, 2025
View reviewed changes
Copy link
Collaborator

@evertlammerts evertlammerts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks! putting this into 1.4.0 :-)

@evertlammerts evertlammerts added this pull request to the merge queue Sep 15, 2025
Merged via the queue into duckdb:v1.4-andium with commit d7df331 Sep 15, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evertlammerts evertlammerts evertlammerts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tishj @evertlammerts