Add support for snowflake and bigquery #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| //"github.com/mithrandie/csvq-driver", | ||
| "github.com/trinodb/trino-go-client/trino", | ||
| "github.com/databricks/databricks-sql-go", | ||
| "github.com/snowflakedb/gosnowflake", |
There was a problem hiding this comment.
Bug: Snowflake Driver Duplicate in Driver Lists
The github.com/snowflakedb/gosnowflake driver is duplicated in both the extra and custom driver lists. This creates an inconsistent categorization, which can lead to confusion for maintainers and potential issues if driver generation logic changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds Snowflake and BigQuery SQL drivers and updates dependencies (incl. AWS SDK) and codegen to support them.
github.com/snowflakedb/gosnowflakeandgithub.com/solcates/go-sql-bigqueryviadrivers.goand add todrivers_gen.gocustomlist.github.com/dave/jennifer/jenand use it indrivers_gen.gofor generatingdrivers.go.[email protected],[email protected].github.com/aws/aws-sdk-go-v2tov1.38.1and update related AWS packages.go.mod/go.sum.Written by Cursor Bugbot for commit 331a703. This will update automatically on new commits. Configure here.