Skip to content

tools/dustElfToBin: Bug fix related to Windows file path and process operation #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

tools/dustElfToBin: Bug fix related to Windows file path and process operation #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions tools/dustElfToBin/dustElfToBin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,21 +93,27 @@ def write_checksum_length_into_file (binFile, elfFile):
def elf_to_bin (binName, elfName):
status = 0
output = ''
toolVer = "6.40.1"
try:
toolBase = os.environ['IAR_ARM_BASE']
toolBase = os.environ['IAR_ARM_BASE']
except KeyError:
toolBase = os.path.join ('/Program Files','IAR Systems', 'EW_ARM_'+toolVer) # default
print >> sys.stderr, "Error: Environment variable IAR_ARM_BASE was not found.\
\nTry to set IAR_ARM_BASE to the top directry of EWARM.\
\n(e.g. C:\\Program Files (x86)\\IAR Systems\\Embedded Workbench 8.0 )"
raise

elfToBin = os.path.join(toolBase, 'arm','bin','ielftool.exe')
execCmd = [elfToBin,'--bin', '--verbose', elfName, binName]
execCmd = [elfToBin, '--bin', '--verbose', elfName, binName]
if os.name in ['nt', 'win32']:
p = Popen(execCmd, shell=False, stdin=None, stdout=PIPE, stderr=STDOUT)
p = Popen(execCmd, shell=True, stdin=None, stdout=PIPE, stderr=STDOUT)
else:
# shell=False means python will handle the quoting for us
p = Popen(execCmd, shell=False, stdin=None, stdout=PIPE, stderr=STDOUT, close_fds=True)
output = p.communicate()[0]
status = p.returncode
if status:
print >> sys.stderr, "Error ielftool.exe returned non-zero exit status ", status
print output
exit(1)
return status, output

# main program
Expand Down