Skip to content

Conversation

@PelayoFelgueroso
Copy link
Collaborator

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

**Closes

@PelayoFelgueroso PelayoFelgueroso marked this pull request as ready for review October 23, 2025 06:24
@Jialecl Jialecl self-requested a review October 23, 2025 08:30
@Jialecl Jialecl self-assigned this Oct 23, 2025
@Jialecl
Copy link
Collaborator

Jialecl commented Oct 23, 2025

A problem with this implementation is that the # does not longer appear in the url when any link or sublink is clicked.
I don't think we want that behaviour.

@PelayoFelgueroso PelayoFelgueroso changed the title Fix Quick Nav bug with React Router > 5 Fix Quick Nav bug with HashRouter Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants