Ndatta/revenue share #423
Ndatta/revenue share #423
Conversation
ndatta-nethermind
requested review from
alexey-kichin,
kzdydx,
therustmonk and
varex83
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_place_order_with_order_router_address( |
There was a problem hiding this comment.
this test should also be what the rev share example showcases
There was a problem hiding this comment.
Can you please explain?
There was a problem hiding this comment.
So what u did here should be in example/re share example not here in mutating node
There was a problem hiding this comment.
I just implemented a test scenario following builder_address. I have added this in reshare example as well.
There was a problem hiding this comment.
I still don’t know why this is still here in mutating node, don’t copy what was done with builder code, bc the same comment applies that should be a separate example, it doesn’t really mutate the node client
There was a problem hiding this comment.
I think it's not resolved?
There was a problem hiding this comment.
A separate example is created in example/revenue_share_example.py file.
There was a problem hiding this comment.
BTW, moved this test code to separate test file.
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_place_order_with_order_router_address( |
There was a problem hiding this comment.
I still don’t know why this is still here in mutating node, don’t copy what was done with builder code, bc the same comment applies that should be a separate example, it doesn’t really mutate the node client
ndatta-nethermind
force-pushed
the
ndatta/revenue-share
branch
from
82eabe9 to
bec461a
Compare
| market = Market( | ||
| (await indexer.markets.get_perpetual_markets(MARKET_ID))["markets"][ | ||
| MARKET_ID | ||
| ] | ||
| ) |
There was a problem hiding this comment.
Add a check to validate if market exist
There was a problem hiding this comment.
These checks are done in the test code instead of example code.
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_place_order_with_order_router_address( |
There was a problem hiding this comment.
I think it's not resolved?
3 participants
No description provided.