Skip to content

fix bug in read-package-json.js, use readFileSync instead of require #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix bug in read-package-json.js, use readFileSync instead of require #355

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4251213
hotfix: use fs.readFileSync instead of require package.json
await-ovo Jul 25, 2019
bf0866d
fix: error capture when read package.json
await-ovo Jul 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/in/read-package-json.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,20 @@
'use strict';

const extend = require('xtend');
const fs = require('fs');

function readPackageJson(filename) {
let pkg;
let error;
try {
pkg = require(filename);
pkg = JSON.parse(fs.readFileSync(filename, 'utf8'));
} catch (e) {
if (e.code === 'MODULE_NOT_FOUND') {
if (e.code === 'ENOENT') {
error = new Error(`A package.json was not found at ${filename}`);
} else {
} else if(e instanceof SyntaxError) {
error = new Error(`A package.json was found at ${filename}, but it is not valid.`);
} else {
error = e;
}
}
return extend({devDependencies: {}, dependencies: {}, error: error}, pkg)
Expand Down