Include ./index.d.ts in the package.
#486
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinusU
reviewed
Jan 5, 2023
|
|
||
| //The default function returns a promise | ||
| export default function(options: INpmCheckOptions): { | ||
| export default function (options: INpmCheckOptions): { |
There was a problem hiding this comment.
This is no longer equivalent, since the previous export used the CJS syntax.
We need to use the same syntax here to work as before:
Suggested change
| export default function (options: INpmCheckOptions): { | |
| export = function (options: INpmCheckOptions): { |
Also, I think that we should remove the declare module block altogether. It only causes problems, and since this file is shipped next to index.js I don't see any reason why to have it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
package.jsondeclares that this package ships with typings, but theindex.d.tsfile is not included in the shipped package.This PR adds that file to the shipped package and does some minor cleanup to the typings.