Fix FMS/WAF Logs processing rule to process cloudfront waf logs
#115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AWS Firewall Manager (FMS) service stores WAF logs in S3 with object paths that include both standard AWS region names (e.g., ap-southeast-2) and the special case cloudfront. While the existing aws_region_pattern regex supports typical region identifiers, it excludes cloudfront—intentionally—since that pattern may also be used in contexts where strict region validation is required.
To address this without altering the original regex behavior, this change introduces a new pattern: aws_fms_waf_region_pattern.
This dedicated pattern is designed to explicitly support both region names and cloudfront, ensuring that all AWS WAF/FMS logs are accurately recognized and processed by the ingestion pipeline.