Extract goroutine management and clean up into a separate package #1362
+401
−147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/orchestrator/internal/sandbox/network/pool.go
djeebus
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
dobrac
requested changes
Oct 18, 2025
| closed bool | ||
| doneCh chan taskResult | ||
| wg sync.WaitGroup | ||
| cancelFunc context.CancelFunc |
There was a problem hiding this comment.
Not a fan of having this context on the struct. Also, the cancelation is incorrect and differs from the initial implementation drastically
| func (s *Runner) Close(ctx context.Context) error { | ||
| // Idempotent: if Run already performed cleanup, nothing to do | ||
| s.mu.Lock() | ||
| if s.cleanupsRun { |
There was a problem hiding this comment.
can be done using atomic boolean
| mu sync.Mutex | ||
| started bool | ||
| closed bool | ||
| doneCh chan taskResult |
There was a problem hiding this comment.
how about using the setonce instead? It could then handle multiple variables on this struct
| tasks []Task | ||
| logger *zap.Logger | ||
|
|
||
| mu sync.Mutex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to test and standardize how we start, monitor, cancel, and clean up our goroutines. This PR only adds it to orchestrator, but we should add this to api, client-proxy, and the rest as well.
Note
Introduces a shared supervisor for task lifecycle and refactors orchestrator to use it for starting, monitoring, and cleanup; removes legacy goroutine/closer logic and tweaks network pool Close.
packages/shared/pkg/supervisor):RunnerwithAddTask,Run, andClosefor task lifecycle management.TaskExitedErrorand tests covering cancellation and early task exit.packages/orchestrator/main.go):errgroup/signal/closers/startServicewithsupervisor.Runnertasks for all services (sandbox proxy,device pool,network pool,hyperloop server,cmux,http,grpc, etc.).cleanupLoggerhelper and registers loggers/clients/batchers/observers asCleanuptasks.runner.Run(ctx)thenrunner.Close(ctx); removesserviceDoneError,closertype, and related logic.internal/sandbox/network/pool.go):Close; functional behavior unchanged.Written by Cursor Bugbot for commit 8ecda4d. This will update automatically on new commits. Configure here.