fix: orchestrator/template manager shutdown exit code #1377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobrac
force-pushed
the
fix-template-manager-shutdown
branch
from
6a6d947 to
62b17cb
Compare
dobrac
commented
Oct 18, 2025
Comment on lines
+192
to
+205
| serviceError := make(chan error) | ||
| defer close(serviceError) | ||
|
|
||
| var g errgroup.Group | ||
| // defer waiting on the group so that this runs even when | ||
| // there's a panic. | ||
| defer func(g *errgroup.Group) { | ||
| err := g.Wait() | ||
| var sde serviceDoneError | ||
| if err != nil && !errors.As(err, &sde) { | ||
| globalLogger.Error("error while waiting for services to finish", zap.Error(err)) | ||
| success = false | ||
| } | ||
| }(&g) |
There was a problem hiding this comment.
just moved down so it can use the global logger
|
this will be refactored differently in: #1362 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix orchestrator/template manager shutdown exit code by properly handling exit errors and improving logger messages observability.