fix: wait for builds to drain before restart #1380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Introduce
ServerStore.Wait
and update orchestrator shutdown to mark draining, wait for propagation, then wait for template builds to finish before closing services.Draining
, then pause 15s (non-local) for propagation.tmpl.Wait(ctx)
before closing services; log errors and affect exit status.ServerStore
):Wait(ctx)
to block until in-flight builds finish and perform non-local delay checks.Close(ctx)
to only close internal resources and return aggregated errors.Written by Cursor Bugbot for commit ac3857b. This will update automatically on new commits. Configure here.