Skip to content

Conversation

dobrac
Copy link
Contributor

@dobrac dobrac commented Oct 19, 2025

Note

Introduce ServerStore.Wait and update orchestrator shutdown to mark draining, wait for propagation, then wait for template builds to finish before closing services.

  • Orchestrator shutdown:
    • Mark service as Draining, then pause 15s (non-local) for propagation.
    • If template manager is running, call tmpl.Wait(ctx) before closing services; log errors and affect exit status.
  • Template manager (ServerStore):
    • Add Wait(ctx) to block until in-flight builds finish and perform non-local delay checks.
    • Simplify Close(ctx) to only close internal resources and return aggregated errors.

Written by Cursor Bugbot for commit ac3857b. This will update automatically on new commits. Configure here.

@dobrac dobrac added the bug Something isn't working label Oct 19, 2025
cursor[bot]

This comment was marked as outdated.

@dobrac dobrac force-pushed the fix-template-manager-drain-on-restart branch from 8750f65 to ac3857b Compare October 19, 2025 08:27
@sitole sitole self-requested a review October 20, 2025 07:22
@dobrac dobrac merged commit 0a60d50 into main Oct 20, 2025
27 checks passed
@dobrac dobrac deleted the fix-template-manager-drain-on-restart branch October 20, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants