[23822] Protect PDPStatelessWriter attributes #6100

juanlofer-eprosima · 2025-10-14T13:31:10Z

Description

This PR attempts to solve the data race produced when a thread clears the attributes of PDPStatelssWriter at mark_all_readers_interested (called in announceParticipantState from events thread, for example), while the values are read from another thread (send_to_fixed_locators called, for example, from the asynchronous send thread → LocatorSelectorSender::send → StatelessWriter::send_nts → PDPStatelessWriter::send_to_fixed_locators).

@Mergifyio backport 3.3.x 3.2.x 2.14.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

mergify · 2025-10-14T22:33:54Z

🧪 CI Insights

Here's what we observed from your CI run for 6875583.

❌ Job Failures

Pipeline	Job	Retries	🔍 CI Insights	📄 Logs
`Fast DDS MacOS CI`	`mac-ci / fastdds_test ()`	`0`	View	View
`Fast DDS Ubuntu CI`	`ubuntu-ci / fastdds_test (RelWithDebInfo)`	`0`	View	View
`Fast DDS Windows CI`	`windows-ci / fastdds_test (RelWithDebInfo, examples), v143`	`1`	View	View

src/cpp/rtps/builtin/discovery/participant/simple/PDPStatelessWriter.cpp

Signed-off-by: Juan Lopez Fernandez <[email protected]>

MiguelCompany · 2025-11-05T15:31:22Z

@Mergifyio backport 3.3.x 3.2.x 2.14.x

mergify · 2025-11-05T15:31:59Z

backport 3.3.x 3.2.x 2.14.x

✅ Backports have been created

#6152 [23822] Protect PDPStatelessWriter attributes (backport #6100) has been created for branch 3.3.x
#6153 [23822] Protect PDPStatelessWriter attributes (backport #6100) has been created for branch 3.2.x
#6154 [23822] Protect PDPStatelessWriter attributes (backport #6100) has been created for branch 2.14.x but encountered conflicts

* Refs #23822. Protect PDPStatelessWriter attributes Signed-off-by: Juan Lopez Fernandez <[email protected]> * Refs #23822. Atomize matched_ attribute Signed-off-by: Juan Lopez Fernandez <[email protected]> * Refs #23822. Protect reader_data_filter_ attribute Signed-off-by: Juan Lopez Fernandez <[email protected]> --------- Signed-off-by: Juan Lopez Fernandez <[email protected]> (cherry picked from commit 6ca678b)

* Refs #23822. Protect PDPStatelessWriter attributes Signed-off-by: Juan Lopez Fernandez <[email protected]> * Refs #23822. Atomize matched_ attribute Signed-off-by: Juan Lopez Fernandez <[email protected]> * Refs #23822. Protect reader_data_filter_ attribute Signed-off-by: Juan Lopez Fernandez <[email protected]> --------- Signed-off-by: Juan Lopez Fernandez <[email protected]> (cherry picked from commit 6ca678b) # Conflicts: # src/cpp/rtps/builtin/discovery/participant/simple/PDPStatelessWriter.cpp # test/blackbox/common/RTPSWithRegistrationWriter.hpp

* Refs #23822. Protect PDPStatelessWriter attributes Signed-off-by: Juan Lopez Fernandez <[email protected]> * Refs #23822. Atomize matched_ attribute Signed-off-by: Juan Lopez Fernandez <[email protected]> * Refs #23822. Protect reader_data_filter_ attribute Signed-off-by: Juan Lopez Fernandez <[email protected]> --------- Signed-off-by: Juan Lopez Fernandez <[email protected]> (cherry picked from commit 6ca678b)

* Refs #23822. Protect PDPStatelessWriter attributes Signed-off-by: Juan Lopez Fernandez <[email protected]> * Refs #23822. Atomize matched_ attribute Signed-off-by: Juan Lopez Fernandez <[email protected]> * Refs #23822. Protect reader_data_filter_ attribute Signed-off-by: Juan Lopez Fernandez <[email protected]> --------- Signed-off-by: Juan Lopez Fernandez <[email protected]> (cherry picked from commit 6ca678b) # Conflicts: # src/cpp/rtps/builtin/discovery/participant/simple/PDPStatelessWriter.cpp # test/blackbox/common/RTPSWithRegistrationWriter.hpp

* Protect PDPStatelessWriter attributes (#6100) * Refs #23822. Protect PDPStatelessWriter attributes Signed-off-by: Juan Lopez Fernandez <[email protected]> * Refs #23822. Atomize matched_ attribute Signed-off-by: Juan Lopez Fernandez <[email protected]> * Refs #23822. Protect reader_data_filter_ attribute Signed-off-by: Juan Lopez Fernandez <[email protected]> --------- Signed-off-by: Juan Lopez Fernandez <[email protected]> (cherry picked from commit 6ca678b) # Conflicts: # src/cpp/rtps/builtin/discovery/participant/simple/PDPStatelessWriter.cpp # test/blackbox/common/RTPSWithRegistrationWriter.hpp * Fix conflicts Signed-off-by: Emilio Cuesta <[email protected]> * Fix backport namespace issues Signed-off-by: Emilio Cuesta <[email protected]> --------- Signed-off-by: Emilio Cuesta <[email protected]> Co-authored-by: juanlofer-eprosima <[email protected]> Co-authored-by: Emilio Cuesta <[email protected]>

juanlofer-eprosima added this to the v3.4.1 milestone Oct 14, 2025

juanlofer-eprosima requested review from richiprosima and removed request for richiprosima October 14, 2025 13:31

github-actions bot added the ci-pending PR which CI is running label Oct 14, 2025

juanlofer-eprosima changed the title ~~[23822] Protect PDPStatelessWriter attributes (fix unsafe reset in mark_all_readers_interested)~~ [23822] Protect PDPStatelessWriter attributes Oct 21, 2025

juanlofer-eprosima force-pushed the tsan/mark_all_readers_interested branch from 9091882 to 66e4d1b Compare October 21, 2025 13:37

juanlofer-eprosima requested review from richiprosima and removed request for richiprosima October 21, 2025 13:37

juanlofer-eprosima commented Oct 21, 2025

View reviewed changes

src/cpp/rtps/builtin/discovery/participant/simple/PDPStatelessWriter.cpp Show resolved Hide resolved

juanlofer-eprosima commented Oct 23, 2025

View reviewed changes

src/cpp/rtps/builtin/discovery/participant/simple/PDPStatelessWriter.cpp Show resolved Hide resolved

juanlofer-eprosima requested review from richiprosima and removed request for richiprosima October 23, 2025 10:28

juanlofer-eprosima force-pushed the tsan/mark_all_readers_interested branch from b66ab54 to c5d9e1d Compare October 29, 2025 15:56

juanlofer-eprosima requested review from richiprosima and removed request for richiprosima October 29, 2025 15:56

juanlofer-eprosima force-pushed the tsan/mark_all_readers_interested branch from c5d9e1d to 0f9e576 Compare October 30, 2025 13:22

juanlofer-eprosima requested review from richiprosima and removed request for richiprosima October 30, 2025 13:23

juanlofer-eprosima added 3 commits November 3, 2025 16:45

Refs #23822. Protect PDPStatelessWriter attributes

1390fff

Signed-off-by: Juan Lopez Fernandez <[email protected]>

Refs #23822. Atomize matched_ attribute

4f00a92

Signed-off-by: Juan Lopez Fernandez <[email protected]>

Refs #23822. Protect reader_data_filter_ attribute

6875583

Signed-off-by: Juan Lopez Fernandez <[email protected]>

juanlofer-eprosima force-pushed the tsan/mark_all_readers_interested branch from 0f9e576 to 6875583 Compare November 3, 2025 15:45

juanlofer-eprosima requested review from richiprosima and removed request for richiprosima November 3, 2025 15:45

juanlofer-eprosima marked this pull request as ready for review November 4, 2025 13:34

MiguelCompany approved these changes Nov 5, 2025

View reviewed changes

MiguelCompany merged commit 6ca678b into master Nov 5, 2025
33 of 38 checks passed

MiguelCompany deleted the tsan/mark_all_readers_interested branch November 5, 2025 15:24

This was referenced Nov 5, 2025

[23822] Protect PDPStatelessWriter attributes (backport #6100) #6152

Open

[23822] Protect PDPStatelessWriter attributes (backport #6100) #6153

Open

[23822] Protect PDPStatelessWriter attributes (backport #6100) #6154

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[23822] Protect PDPStatelessWriter attributes #6100

[23822] Protect PDPStatelessWriter attributes #6100

Uh oh!

juanlofer-eprosima commented Oct 14, 2025 •

edited by MiguelCompany

Loading

Uh oh!

mergify bot commented Oct 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MiguelCompany commented Nov 5, 2025

Uh oh!

mergify bot commented Nov 5, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[23822] Protect PDPStatelessWriter attributes #6100

[23822] Protect PDPStatelessWriter attributes #6100

Uh oh!

Conversation

juanlofer-eprosima commented Oct 14, 2025 • edited by MiguelCompany Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

mergify bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 CI Insights

❌ Job Failures

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MiguelCompany commented Nov 5, 2025

Uh oh!

mergify bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

juanlofer-eprosima commented Oct 14, 2025 •

edited by MiguelCompany

Loading

mergify bot commented Oct 14, 2025 •

edited

Loading

mergify bot commented Nov 5, 2025 •

edited

Loading