Skip to content

Test oversubscription implemented in framework with HPL easyblock #3920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Test oversubscription implemented in framework with HPL easyblock #3920

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41bddb4
Switch to oversubscription by autogenerated by EB
Crivella Sep 10, 2025
6f4141a
Properly avoid running MPI tests since we are not doing pinning anymore
Crivella Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 9 additions & 21 deletions easybuild/easyblocks/h/hpl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,6 @@ def test_step(self):
srcdir = os.path.join(self.cfg['start_dir'], 'bin', 'UNKNOWN')
change_dir(srcdir)

pre_cmd = ""
post_cmd = ""

# xhpl needs atleast 4 processes to run the test suite
req_cpus = 4

Expand All @@ -137,24 +134,15 @@ def test_step(self):

parallel = self.cfg.parallel
if not build_option('mpi_tests'):
self.log.info("MPI tests disabled from buildoption. Setting parallel to 1")
parallel = 1

if parallel < req_cpus:
self.log.info("Running tests with 1 oversubscribed process")

pin_str = ','.join(["0"] * req_cpus)
if mpi_fam in [toolchain.INTELMPI]:
pre_cmd = f"I_MPI_PIN_PROCESSOR_LIST=\"{pin_str}\" I_MPI_PIN=on "
elif mpi_fam in [toolchain.OPENMPI]:
post_cmd = f"--cpu-set {pin_str}"
elif mpi_fam in [toolchain.MPICH]:
post_cmd = f"-bind-to user:{pin_str}"
else:
self.report_test_failure("Don't know how to oversubscribe for `%s` MPI family" % mpi_fam)

cmd = self.toolchain.mpi_cmd_for(f'{post_cmd} ./xhpl', req_cpus)
cmd = f'{pre_cmd} {cmd}'
self.log.warning("MPI tests disabled from buildoption. Skipping tests")
return

oversubscribe = parallel < req_cpus

try:
cmd = self.toolchain.mpi_cmd_for(f'./xhpl', req_cpus, oversubscribe=oversubscribe)
except EasyBuildError as err:
self.report_test_failure(f"Could not create MPI command to run xhpl: {err}")
res = run_shell_cmd(cmd)
out = res.output

Expand Down
Loading