Skip to content

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Sep 11, 2025

This reverts commit 7429645, from #3918

            for pattern, regex_cmd in self.cfg.get_ref('cmds_map'):
                pattern = pattern % self.cfg.template_values
                regex_cmd = regex_cmd % self.cfg.template_values

Is equivalent to for pattern, regex_cmd in self.cfg['cmds_map']: because the index-access resolves the template and does so recursively.
Hence we can keep the simpler code.

…2843_new_pr_cmdcp"

This reverts commit 7429645, reversing
changes made to 59fa0db.
@Flamefire Flamefire marked this pull request as draft September 11, 2025 15:21
@Flamefire Flamefire marked this pull request as ready for review September 11, 2025 15:31
@Flamefire
Copy link
Contributor Author

Test report by @Flamefire

Overview of tested easyconfigs (in order)

  • SUCCESS STREAM-5.10-GCC-11.3.0.eb
  • SUCCESS STREAM-5.10-intel-compilers-2022.2.1.eb
  • SUCCESS STREAM-5.10-intel-compilers-2024.2.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
login1.barnard.hpc.tu-dresden.de - Linux RHEL 8.9 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (sapphirerapids), Python 3.9.18
See https://gist.github.com/Flamefire/fcf5c06fdea9241c28a782926f9f3729 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants