enhance PythonPackage easyblock to error out when only build-options are given for pip-based Python package installation
#3925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age installation When no separate build command is used to build Python packages, e.g. when using pip, the build options will be ignored. This may be surprising as it is different to any other build. Error out in this case. Do not error when build- and install-options are set as that might be intentional to support run-time choices e.g. by easyblocks. Also include a clear hint to pip if it is used.
boegel
changed the title
PythonPackage easyblock to error out when only build-options are given for pip-based Python package installation
boegel
changed the title
PythonPackage easyblock to error out when only build-options are given for pip-based Python package installationPythonPackage easyblock to error out when only build-options are given for pip-based Python package installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no separate build command is used to build Python packages, e.g. when using pip, the build options will be ignored. This may be surprising as it is different to any other build.
Error out in this case.
Do not error when build- and install-options are set as that might be intentional to support run-time choices e.g. by easyblocks. Also include a clear hint to pip if it is used.