Skip to content

retry fetching extensions from PyPI with alternative download_filename #4943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
+15 −1
Open

retry fetching extensions from PyPI with alternative download_filename #4943

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c61c437
retry fetching extensions from PyPI with alternative download_filename
Jun 27, 2025
04da499
use is_pypi_source variable name
Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion easybuild/framework/easyblock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,9 +717,13 @@ def collect_exts_file_info(self, fetch_files=True, verify_checksums=True):

# if no sources are specified via 'sources', fall back to 'source_tmpl'
src_fn = ext_options.get('source_tmpl')
is_pypi_source = False
if src_fn is None:
# use default template for name of source file if none is specified
src_fn = '%(name)s-%(version)s.tar.gz'
if len(source_urls) == 1 and PYPI_PKG_URL_PATTERN in source_urls[0]:
# allow retrying with alternative download_filename
is_pypi_source = True
elif not isinstance(src_fn, str):
error_msg = "source_tmpl value must be a string! (found value of type '%s'): %s"
raise EasyBuildError(error_msg, type(src_fn).__name__, src_fn)
Expand All @@ -729,7 +733,17 @@ def collect_exts_file_info(self, fetch_files=True, verify_checksums=True):
if fetch_files:
src_path = self.obtain_file(src_fn, extension=True, urls=source_urls,
force_download=force_download,
download_instructions=download_instructions)
download_instructions=download_instructions,
warning_only=is_pypi_source)
if not src_path and is_pypi_source:
# retry with alternative download_filename
alt_name = resolve_template('%(name)s', template_values).replace("-", "_")
src_version = resolve_template('%(version)s', template_values)
alt_download_fn = f'{alt_name}-{src_version}.tar.gz'
src_path = self.obtain_file(src_fn, extension=True, urls=source_urls,
force_download=force_download,
download_instructions=download_instructions,
download_filename=alt_download_fn)
if src_path:
ext_src.update({'src': src_path})
else:
Expand Down