Remove some unneeded promises #1940
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregorio Litenstein <[email protected]>
On macOS, running via `npm run` makes `moveToNextScreen` go down the linux instead of the darwin branch, which eventually leads to `getLaunchArgs is not a function` error. Signed-off-by: Gregorio Litenstein <[email protected]>
Signed-off-by: Gregorio Litenstein <[email protected]> Remove catch…throw blocks Weird, I was sure I had fixed them before. Signed-off-by: Gregorio Litenstein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've remade this PR by cherry-picking and squashing the commits from the original onto the latest develop branch.
Tests on my fork look fine. Locally, tests succeed except for the install logic ones (I suspect there's an issue with the paths but not sure what), and running it locally with a mock profile seems to work fine.
Of note: There are still several
new PromiseandPromise.resolveand.thenbits in the code. It's very likely that most of those can be changed to use await, but I'd rather leave them to someone else for now.