Update parsing of sampling to match tsp specification #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tsp-typescript-client was modified to comply to tsp specification for sampling, update accordingly here.
PatrickTasse
previously approved these changes
Oct 16, 2025
The tsp-typescript-client was modified to comply to tsp specification for sampling, update accordingly here. Account for new xRanges and xCategories for generic xy output component. Contributes to fix: eclipse-tracecompass-incubator/org.eclipse.tracecompass.incubator#236 Upgrade to tsp-typescript-client v0.9.0. Signed-off-by: Bernd Hufmann <[email protected]>
PatrickTasse
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tsp-typescript-client was modified to comply to tsp specification for sampling. This change synchronizes the implementation.
What it does
Update to match the latest update in tsp-typescript-client: eclipse-cdt-cloud/tsp-typescript-client#144
Related issue: eclipse-tracecompass-incubator/org.eclipse.tracecompass.incubator#236
How to test
Can be tested with a lttng-ust trace using function density view, everything should work the same as previously.
Follow-ups
No follow-ups.
Review checklist