Support generic object data provider #358
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add DataOutputComponent with JSON Editor for the object and Next and Previous buttons for navigation. Update data on change of selectionRange Support DATA provider type in TraceContextComponent. Signed-off-by: Patrick Tasse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Add DataOutputComponent with JSON Editor for the object and Next and Previous buttons for navigation.
Update data on change of selectionRange
Support DATA provider type in TraceContextComponent.
How to test
Open an output with DATA type like Raw Events Data.
Navigate with Next and Previous buttons.
Follow-ups
Consider a standard way to limit the size of data given to the JSON Editor to prevent slowdown and out of memory errors.
Review checklist