-
Notifications
You must be signed in to change notification settings - Fork 84
Parser profiler #1993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parser profiler #1993
Conversation
Thanks, I'll take closer look at this next week! |
Thanks. Happy to move things around and adjust behaviour as required - have set aside some time next week to get this in if possible. Just let me know :) |
A small success story from use of this profiling tool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I think this is already looking really nice! I believe there are a few more places where we could benefit from the profiling support (lexer, indexing), but these can be implemented separately.
Please see my comments below.
@msujew thanks! Hopefully those should be addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I did some additional manual testing, and this works really well.
Closes #1996