Add support for using a hosted eclipse platform as target #1624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
force-pushed
the
add_support_for_hosted_projects_in_target
branch
from
336e8fc to
612f45a
Compare
Isn't this already handled by the target-platform weaving done by PDE based on the dev-classpath of Equinox? |
If then it seem to not work in all situations. |
laeubi
force-pushed
the
add_support_for_hosted_projects_in_target
branch
from
612f45a to
dc16218
Compare
Currently if one uses the "Running Platform" in an Eclipse launched from within an SDK it can happen that a project from the host workspace is chosen as a dependency. In such case there are some issues that only the root folder is added and then compilation fails. This now enhances the PDEClasspathContainer to detect the situation and adding the output folders instead of the root.
laeubi
force-pushed
the
add_support_for_hosted_projects_in_target
branch
from
dc16218 to
3aefcb7
Compare
|
I convert this to draft as I currently did not see any issues... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if one uses the "Running Platform" in an Eclipse launched from within an SDK it can happen that a project from the host workspace is chosen as a dependency. In such case there are some issues that only the root folder is added and then compilation fails.
This now enhances the PDEClasspathContainer to detect the situation and adding the output folders instead of the root.