Applications list is filtered using the plugins from the product #1935
+49
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Krishneet Raj <[email protected]> Co-authored-by: Lu Tri Vi Huynh <[email protected]>
Co-authored-by: Krishneet Raj <[email protected]> Co-authored-by: Lu Tri Vi Huynh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue where the list of applications included all applications, even invalid ones like "org.eclipse.equinox.p2.director" , which caused the product to fail when launched with those invalid applications.
Was fixed it collaboration with my teammates: @krishneetRAJ and @vihuynh72.
We implemented a way of filtering the list of applications by getting the plugins/dependencies from the product and filtering the list using the plugins. The more plugins you add the more applications will be available.
Fixes issue : #1052
Before:
After:
The list above was filtered using these plugins: