Skip to content

Possible misspelling of function name for changesForModelModication() #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Possible misspelling of function name for changesForModelModication() #1941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/nls/ExternalizeStringsOperation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ protected void execute(IProgressMonitor monitor) throws CoreException, Invocatio

private void getChangeForBuild(IFile buildPropsFile, IProgressMonitor monitor, CompositeChange parent, final String localization) {
// Create change
TextFileChange[] changes = PDEModelUtility.changesForModelModication(new ModelModification(buildPropsFile) {
TextFileChange[] changes = PDEModelUtility.changesForModelModification(new ModelModification(buildPropsFile) {
@Override
protected void modifyModel(IBaseModel model, IProgressMonitor monitor) throws CoreException {

Expand Down Expand Up @@ -192,7 +192,7 @@ private void addBundleLocalization(ModelChange change, IProgressMonitor mon, Com
return;
}
final String localiz = change.getBundleLocalization();
TextFileChange[] result = PDEModelUtility.changesForModelModication(new ModelModification(manifest) {
TextFileChange[] result = PDEModelUtility.changesForModelModification(new ModelModification(manifest) {
@Override
protected void modifyModel(IBaseModel model, IProgressMonitor monitor) throws CoreException {
if (model instanceof IBundlePluginModelBase bundleModel) {
Expand Down
6 changes: 4 additions & 2 deletions ...pse.pde.ui/src/org/eclipse/pde/internal/ui/refactoring/RenameExtensionPointProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ public RefactoringParticipant[] loadParticipants(RefactoringStatus status, Shara
protected void changeExtensionPoint(CompositeChange compositeChange, IProgressMonitor monitor) {
IFile file = getModificationFile(fInfo.getBase());
if (file != null) {
compositeChange.addAll(PDEModelUtility.changesForModelModication(getExtensionPointModification(file), monitor));
compositeChange
.addAll(PDEModelUtility.changesForModelModification(getExtensionPointModification(file), monitor));
}
}

Expand All @@ -115,7 +116,8 @@ private void findReferences(CompositeChange compositeChange, IProgressMonitor mo
for (int i = 0; i < bases.length; i++) {
IFile file = getModificationFile(bases[i]);
if (file != null) {
compositeChange.addAll(PDEModelUtility.changesForModelModication(getExtensionModification(file), subMonitor.split(1)));
compositeChange.addAll(PDEModelUtility.changesForModelModification(getExtensionModification(file),
subMonitor.split(1)));
}
subMonitor.setWorkRemaining(bases.length - i);
}
Expand Down
3 changes: 2 additions & 1 deletion ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/util/PDEModelUtility.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,8 @@ public static void modifyModel(final ModelModification modification, final IProg
}
}

public static TextFileChange[] changesForModelModication(final ModelModification modification, final IProgressMonitor monitor) {
public static TextFileChange[] changesForModelModification(final ModelModification modification,
final IProgressMonitor monitor) {
final PDEFormEditor editor = getOpenEditor(modification);
if (editor != null) {
Display.getDefault().syncExec(() -> {
Expand Down
2 changes: 1 addition & 1 deletion ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/wizards/tools/OrganizeManifest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ public static TextFileChange[] removeUnusedKeys(final IProject project, final IB
return new TextFileChange[0];
}

return PDEModelUtility.changesForModelModication(new ModelModification(propertiesFile) {
return PDEModelUtility.changesForModelModification(new ModelModification(propertiesFile) {
@Override
protected void modifyModel(IBaseModel model, IProgressMonitor monitor) throws CoreException {
if (!(model instanceof IBuildModel)) {
Expand Down
2 changes: 1 addition & 1 deletion ...ipse.pde.ui/src/org/eclipse/pde/internal/ui/wizards/tools/OrganizeManifestsProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ protected void modifyModel(IBaseModel model, IProgressMonitor monitor) throws Co
}
}
};
Change[] changes = PDEModelUtility.changesForModelModication(modification, subMonitor);
Change[] changes = PDEModelUtility.changesForModelModification(modification, subMonitor);
for (Change changeItem : changes) {
change.add(changeItem);
}
Expand Down
Loading