Skip to content

Conversation

@BeckerWdf
Copy link
Contributor

Use SVGs instead of PNGs as platform now supports this.

All SVG already existing and were simply copied over.

For the preference_spy.png an SVG still needs to be created. This will be done in a separate commit.

Contributes to: #1927

@BeckerWdf
Copy link
Contributor Author

The expand / collape all, delete / delete all where greyed out in the current state (PNGs). This looked like these actions are disabled. See:
Screenshot 2025-09-03 at 08 22 49

I think they should be colorful like the other versions of these in platform. So I changed this.
See:
image
image

@HannesWell: Can you pls. review and and manually test?

@eclipse-pde-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

features/org.eclipse.pde.spies-feature/feature.xml
ui/org.eclipse.pde.spy.preferences/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 2df8fe9af637b8e789bd83c40f7924d742c1c2de Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <[email protected]>
Date: Wed, 3 Sep 2025 06:42:38 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/features/org.eclipse.pde.spies-feature/feature.xml b/features/org.eclipse.pde.spies-feature/feature.xml
index 1a482dead2..281945dff8 100644
--- a/features/org.eclipse.pde.spies-feature/feature.xml
+++ b/features/org.eclipse.pde.spies-feature/feature.xml
@@ -2,7 +2,7 @@
 <feature
       id="org.eclipse.pde.spies"
       label="%featureName"
-      version="1.0.800.qualifier"
+      version="1.0.900.qualifier"
       provider-name="%providerName"
       license-feature="org.eclipse.license"
       license-feature-version="0.0.0">
diff --git a/ui/org.eclipse.pde.spy.preferences/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.spy.preferences/META-INF/MANIFEST.MF
index 4e9346f6cd..3e2b3e3a75 100644
--- a/ui/org.eclipse.pde.spy.preferences/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.spy.preferences/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.pde.spy.preferences;singleton:=true
-Bundle-Version: 0.13.600.qualifier
+Bundle-Version: 0.13.700.qualifier
 Automatic-Module-Name: org.eclipse.pde.spy.preferences
 Bundle-RequiredExecutionEnvironment: JavaSE-17
 Bundle-Vendor: %provider-name
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link

github-actions bot commented Sep 3, 2025

Test Results

   771 files  ±0     771 suites  ±0   1h 19m 18s ⏱️ + 1m 50s
 3 609 tests ±0   3 556 ✅  - 1   52 💤 ±0  1 ❌ +1 
10 827 runs  ±0  10 669 ✅  - 1  157 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 87c7578. ± Comparison against base commit 46ec758.

♻️ This comment has been updated with latest results.

Use SVGs instead of PNGs as platform now supports this.

All SVG already existing and were simply copied over.

For the preference_spy.png an SVG still needs to be created.
This will be done in a separate commit.

Contributes to: eclipse-pde#1927
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants