Skip to content

SWT: Respect Windows accessibility cursor size setting #2493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SWT: Respect Windows accessibility cursor size setting #2493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Cursor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import org.eclipse.swt.*;
import org.eclipse.swt.internal.*;
import org.eclipse.swt.internal.win32.*;
import org.eclipse.swt.internal.win32.version.*;

/**
* Instances of this class manage operating system resources that
Expand Down Expand Up @@ -349,6 +350,39 @@ private void setHandleForZoomLevel(CursorHandle handle, Integer zoom) {
}
}

/**
* Retrieves the scaling factor of the mouse pointer size as set in Windows
* 10/11 "Settings > Accessibility > Mouse pointer and touch > Size".
* <p>
* This method reads the "CursorBaseSize" registry value under
* {@code HKEY_CURRENT_USER\Control Panel\Cursors}. If this registry value
* exists (introduced in Windows 10 version 1809 for accessibility cursor
* scaling), the method computes the scale factor by dividing the base size by
* the default system cursor size (32px). If the registry value is not present
* or cannot be read, the method returns {@code 1} indicating default size.
* <p>
* <strong>Note:</strong> This approach is only valid for Windows 10 1809+ with
* the modern accessibility pointer setting. For classic themes or older Windows
* versions, this value may not be present or honored.
*
* @return the cursor scaling factor (e.g., 1 for default size, 2 for double
* size, etc.)
*/

private static int getPointerSizeScaleFactor() {
final int defaultCursorSize = 32;
int scaleFactor = 1; // Default: standard size

if (OsVersion.IS_WIN10_1809) {
int[] cursorBaseSize = OS.readRegistryDwords(OS.HKEY_CURRENT_USER, "Control Panel\\Cursors", "CursorBaseSize");
if (cursorBaseSize != null && cursorBaseSize.length > 0 && cursorBaseSize[0] > 0) {
scaleFactor = cursorBaseSize[0] / defaultCursorSize;
}
}

return scaleFactor;
}

@Override
void destroy () {
device.deregisterResourceWithZoomSupport(this);
Expand Down Expand Up @@ -635,7 +669,8 @@ public ImageDataCursorHandleProvider(ImageData source, int hotspotX, int hotspot

@Override
public CursorHandle createHandle(Device device, int zoom) {
ImageData scaledSource = DPIUtil.scaleImageData(device, this.source, zoom, DEFAULT_ZOOM);
int accessibilityFactor = getPointerSizeScaleFactor();
ImageData scaledSource = DPIUtil.scaleImageData(device, this.source, zoom * accessibilityFactor, DEFAULT_ZOOM);
return setupCursorFromImageData(device, scaledSource, getHotpotXInPixels(zoom),
getHotpotYInPixels(zoom));
}
Expand Down
Loading