[Win32] Return unrounded value in FontMetrics.getAverageCharacterWidth #2496
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
reviewed
Sep 11, 2025
There was a problem hiding this comment.
Thank you for the proposal! Since FontMetrics is a kind of central class (thus adapting it is critical) some more information about potential impacts (such as on the various consumers in the Eclipse Platform) and how far they were or need to be tested would be good. Also some information on how to test and reproduce changes in behavior would be nice.
@ptziegler fyi, as Draw2d's TextUtilities make use of this method
| @@ -108,7 +108,7 @@ public int getAscent() { | |||
| * @since 3.107 | |||
| */ | |||
| public double getAverageCharacterWidth() { | |||
| return getAverageCharWidth(); | |||
| return DPIUtil.pixelToPoint((float)handle.tmAveCharWidth, getZoom()); | |||
There was a problem hiding this comment.
Shouldn't we add a method converting doubles instead of trimming to float and then converting back?
The value for getAverageCharacterWidth was rounded, even though its method signature returns a double. The unrounded value provides a better estimation of the average character width for non-integer zoom factors. Fixes: eclipse-platform#2461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2461