-
Notifications
You must be signed in to change notification settings - Fork 34
Add JWT support for gRPC server #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jotschi
wants to merge
9
commits into
eclipse-vertx:main
Choose a base branch
from
Jotschi:dev-grpc-jwt-support-3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
01248c4
Add JWT support for gRPC server
Jotschi 1924b3d
Add usage examples to doc
Jotschi 5d608d5
Add GrpcAuthenticationHandler and make use of handlers more generic a…
Jotschi db495c4
Pass the authentication handler along via the callHandler method and …
Jotschi dbf16e0
Remove GrpcServerRequest#setUser from interface
Jotschi 70cb230
Add JWT support for gRPC client
Jotschi 3632bd0
Fix upstream codegen support
Jotschi e1ad4fc
Align testcode with upstream API changes
Jotschi 3eefc85
Change withCredentials to credentials
Jotschi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 6 additions & 4 deletions
10
vertx-grpc-server/src/main/java/examples/HelloWorldProto.java
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
42 changes: 42 additions & 0 deletions
42
vertx-grpc-server/src/main/java/io/vertx/grpc/server/GrpcException.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| package io.vertx.grpc.server; | ||
|
|
||
| import io.vertx.core.http.HttpClientResponse; | ||
| import io.vertx.grpc.common.GrpcStatus; | ||
|
|
||
| public class GrpcException extends RuntimeException { | ||
|
|
||
| private static final long serialVersionUID = -7838327176604697641L; | ||
|
|
||
| private GrpcStatus status; | ||
|
|
||
| private HttpClientResponse httpResponse; | ||
|
|
||
| public GrpcException(String msg, GrpcStatus status, | ||
| HttpClientResponse httpResponse) { | ||
| super(msg); | ||
| this.status = status; | ||
| this.httpResponse = httpResponse; | ||
| } | ||
|
|
||
| public GrpcException(GrpcStatus status) { | ||
| this.status = status; | ||
| } | ||
|
|
||
| public GrpcException(GrpcStatus status, Throwable err) { | ||
| super(err); | ||
| this.status = status; | ||
| } | ||
|
|
||
| public GrpcException(GrpcStatus status, String msg) { | ||
| super(msg); | ||
| this.status = status; | ||
| } | ||
|
|
||
| public GrpcStatus status() { | ||
| return status; | ||
| } | ||
|
|
||
| public HttpClientResponse response() { | ||
| return httpResponse; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
vertx-grpc-server/src/main/java/io/vertx/grpc/server/auth/GrpcAuthenticationHandler.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| package io.vertx.grpc.server.auth; | ||
|
|
||
| import io.vertx.codegen.annotations.VertxGen; | ||
| import io.vertx.core.Future; | ||
| import io.vertx.core.http.HttpServerRequest; | ||
| import io.vertx.ext.auth.User; | ||
| import io.vertx.grpc.server.GrpcServer; | ||
|
|
||
| /** | ||
| * Authentication handler for {@link GrpcServer}. | ||
| */ | ||
| @VertxGen | ||
| @FunctionalInterface | ||
| public interface GrpcAuthenticationHandler { | ||
|
|
||
| /** | ||
| * Authenticate the provided request and return the authenticated user. | ||
| * | ||
| * @param httpRequest Request to authenticate | ||
| * @param requireAuthentication Whether the handler should fail when no authentication is present | ||
| * @return | ||
| */ | ||
| Future<User> authenticate(HttpServerRequest httpRequest, boolean requireAuthentication); | ||
|
|
||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need this I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the setter from the interface but the getter is required. Otherwise a user of the API is unable to access the authenticated user. At this point there is no "Context" object for gRPC so I put the user in the request.