-
Notifications
You must be signed in to change notification settings - Fork 47
Factorize duplication between trltog and trgtol (cpu only) #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Thanks for this @dhaumont. Naturally it'll take some time to test, but assuming you've done your homework this could be a really nice restructuring. Just a quick suggestion: |
|
@samhatfield The code is not properly tested on my side, it is really still WIP. About merging the code iinto parent subourtine, I did my best to move as much as I could, and what is left are the communication routines. But indeed we can still go further and have a single file for both. |
|
If I understand what you said the other day @dhaumont, you're well aware that this isn't finished, and just want some early feedback on the overall idea before you commit more time to finishing it. I think in principle we'd be happy to accept a change like this. My only concern is that we're introducing a lot more variables (derived types) that are now wrapping the other variables. So it's sort of more complicated and less complicated at the same time. With time maybe we can simplify even further without making the code more of a headache. Maybe we could work on this PR together, and keep it up to date with develop. Eventually we might decide not to merge it, but it wouldn't be a waste of time because we would learn a lot about My question is, is this PR related to your FIELD API developments or is it orthogonal? |
This PR is a refactoring to eliminate duplicated code between trltog and trgtol in the cpu branch.
The duplicated codehas been extracted into new routines in a new module trgl_mod, and they are called from trltog and trgtol.
IMPORTANT: The PR is still a draft and was not completely tested nor properly validated.