Added a running window over the future for most debiasers #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A running window over the future period is useful to smooth out preserved trends when bias adjusting. Functionality for this existed in the QDM and CDFt classes, but not in others. Updates: - New general class: SeasonalAndFutureRunningWindowDebiaser, inheriting from the SeasonalRunningWindowDebiaser (formerly RunningWindowDebiaser) implementing seasonal running window and one over the future period. - Changed CDFt, SDM, QDM, ECDFM and QM to inherit from that class in order to add this functionality to the classes. For QDM the implementation is slightly slower than earlier versions as pre-computation was done before the future running window application, but tests showed that this is in the order of ~1-2% and the code is strongly simplified that way.
Use length of 31 years and step length of 9 years as default. Default: off. Updates do docs.
…or backwards compatibility
jakobwes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This accounts for the temporal evolution of trends. It was already implemented for CDFt and QDM and is extended to SDM, ECDFM , QuantileMapping. It is not necessary for LinearScaling nor for ISIMIP.