Skip to content

Conversation

Oisin-M
Copy link
Contributor

@Oisin-M Oisin-M commented Sep 9, 2025

Description

Remove __init__.py from earthkit, and have all packages instead use earthkit-utils. This will allow import earthkit as ek; ek.subpkg to work regardless of the install method. Close #100.

Draft PR until eku is ready (and will need to pin eku version).

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@Oisin-M
Copy link
Contributor Author

Oisin-M commented Sep 12, 2025

Github action tests failing with a version issue (version file not being found), which I believe is caused by fetch-depth: 1 when checking out the repo. Locally the tests are passing for me

@Oisin-M
Copy link
Contributor Author

Oisin-M commented Sep 15, 2025

Previous theory was incorrect. The issue was that git removes empty folders and this was causing the version file writing to fail

@Oisin-M Oisin-M marked this pull request as ready for review September 15, 2025 08:43
@sandorkertesz sandorkertesz merged commit 0894098 into develop Sep 18, 2025
119 checks passed
@sandorkertesz sandorkertesz deleted the feat/remove_init branch September 18, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve earthkit import system
2 participants