Use current Packagist v2 API endpoints instead of the now defunct v1 API endpoints. #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump guzzlehttp/guzzle from 7.9.3 to 7.10.0 Bumps [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) from 7.9.3 to 7.10.0. - [Release notes](https://github.com/guzzle/guzzle/releases) - [Changelog](https://github.com/guzzle/guzzle/blob/7.10/CHANGELOG.md) - [Commits](guzzle/guzzle@7.9.3...7.10.0) --- updated-dependencies: - dependency-name: guzzlehttp/guzzle dependency-version: 7.10.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Bump composer/semver from 3.4.3 to 3.4.4 Bumps [composer/semver](https://github.com/composer/semver) from 3.4.3 to 3.4.4. - [Release notes](https://github.com/composer/semver/releases) - [Changelog](https://github.com/composer/semver/blob/main/CHANGELOG.md) - [Commits](composer/semver@3.4.3...3.4.4) --- updated-dependencies: - dependency-name: composer/semver dependency-version: 3.4.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
This change is needed because the v1 repository on repo.packagist.org is no longer available and thus this tool can no longer fetch meta data from it and thus calculate libyears from it, rendering it useless.
|
@WyriHaximus @SteveDesmond-ca @greg0ire @prajapati-kaushik did one of you already find the time to have a look at this? It would be greatly apreciated, since the latest release is broken 👍 |
|
It's on my radar, can hopefully get a new release out this week. |
SteveDesmond-ca
force-pushed
the
main
branch
from
ad981e8 to
3f40b2a
Compare
Comment on lines
28
to
36
| $response = $this->http_client->request('GET', "$url/packages.json"); | ||
| $result = json_decode($response->getBody()->getContents(), true) ?? []; | ||
|
|
||
| // For the new packagist.org, override the deprecated metadata-url | ||
| if ($url === 'https://packagist.org') { | ||
| return new Repository($url, '/packages/%package%.json'); | ||
| } | ||
|
|
||
| return new Repository($url, array_key_exists('metadata-url', $result) ? $result['metadata-url'] : null); |
There was a problem hiding this comment.
Thanks -- everything else looks good, but I want to think a little more on this part...it feels off, but it's also been years since I've really worked with this app's code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This change is needed because Composer v1 is no longer available as of September 1st, apparently this also means that the Packagist API got cleaned up and some endpoints were removed. It turns out that https://repo.packagist.org is no longer available which was still heavily used in this codebase.
For more info, see https://blog.packagist.com/packagist-org-shutdown-of-composer-1-x-support-postponed-to-september-1st-2025/ for more information on deprecating composer v1.
What has been done
How to test
Broken behaviour:
Fixed behaviour: