Rename tau parameter to WithdrawTax in RiskyContribModel #1582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue where the
tau
parameter in RiskyContribModel used a symbolic name instead of an economic name, which goes against HARK's naming conventions.Changes Made
tau
toWithdrawTax
throughout the RiskyContribModel"WithdrawTax": [0.0]
to default parameterstime_vary_
list to include "WithdrawTax"Economic Meaning
The parameter represents a tax rate applied to withdrawals from risky assets to risk-free assets. The new name
WithdrawTax
clearly conveys this economic meaning and follows HARK's convention of using descriptive names likeDiscFac
,PermGroFac
,BoroCnstArt
, etc.Files Modified
HARK/ConsumptionSaving/ConsRiskyContribModel.py
- Main model implementationtests/ConsumptionSaving/test_ConsRiskyContribModel.py
- Test fileThe changes are minimal and surgical, preserving all existing functionality while making the parameter name economically meaningful.
Fixes #1539.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.