Support ND neigh-suppress config and show cli command #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if vxlan_keys is not None: | ||
| for key in natsorted(vxlan_keys): | ||
| key1 = vxlan_table[key]['vlan'] | ||
| netdev = vxlan_keys[0][0]+"-"+key1[4:] |
There was a problem hiding this comment.
Using vxlan_keys[0] to construct the netdev identifier may yield incorrect results when iterating over multiple keys; consider using the current key from the loop instead.
Suggested change
| netdev = vxlan_keys[0][0]+"-"+key1[4:] | |
| netdev = key[0]+"-"+key1[4:] |
| body.append([vxlan_table[key]['vlan'], supp_str, netdev]) | ||
| click.echo(tabulate(body, header, tablefmt="grid")) | ||
| return | ||
| print(vlan + " is not configured in vxlan tunnel map table") |
There was a problem hiding this comment.
For consistency with click-based output, replace the use of print() with click.echo() to ensure uniform behavior across command outputs.
Suggested change
| print(vlan + " is not configured in vxlan tunnel map table") | |
| click.echo(vlan + " is not configured in vxlan tunnel map table") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add cli show and config command for nd suppress