Add config and show cli command for neigh-suppress #48
+86
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if vxlan_keys is not None: | ||
| for key in natsorted(vxlan_keys): | ||
| key1 = vxlan_table[key]['vlan'] | ||
| netdev = vxlan_keys[0][0]+"-"+key1[4:] |
There was a problem hiding this comment.
Using vxlan_keys[0][0] inside the loop may not correctly reflect the current key being processed. Consider using the current key variable (e.g., 'key') to construct netdev to avoid potential mismatches.
Suggested change
| netdev = vxlan_keys[0][0]+"-"+key1[4:] | |
| netdev = key[0]+"-"+key1[4:] |
| @click.argument('vid', metavar='<vid>', required=True, type=int) | ||
| @click.argument('state', metavar='<on|off>', required=True, type=click.Choice(["on", "off"])) | ||
| @clicommon.pass_db | ||
| def set_neigh_suppress(db, vid, state): |
There was a problem hiding this comment.
The variable 'ctx' is used but not defined in this function. Pass the click context via a parameter or use appropriate error reporting like click.echo before exiting.
Suggested change
| def set_neigh_suppress(db, vid, state): | |
| def set_neigh_suppress(db, vid, state): | |
| ctx = click.get_current_context() |
| body.append([vxlan_table[key]['vlan'], supp_str, netdev]) | ||
| click.echo(tabulate(body, header, tablefmt="grid")) | ||
| return | ||
| print(vlan + " is not configured in vxlan tunnel map table") |
There was a problem hiding this comment.
Using print here is inconsistent with the rest of the CLI output which uses click.echo. Consider replacing print with click.echo to maintain a consistent output format.
Suggested change
| print(vlan + " is not configured in vxlan tunnel map table") | |
| click.echo(vlan + " is not configured in vxlan tunnel map table") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support ND suppress command.
What I did
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)