Fix diffTypesFor() when using a file extension
#1097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `diffTypesFor()` function is intended to allow you to pass in a MediaType object, media type string, or a file extension (e.g. `".pdf"`). However, it turns out the file extension is broken (I guess we have pretty much stopped using file extensions since we improved media type support way back when...). This fixes the issue and adds a test. This bug was originally uncovered by @BeckettFrey in #1095.
Mr0grog
deleted the
you-might-try-to-get-the-diff-types-for-an-extension-but-you-would-fail
branch
Mr0grog
added a commit
to edgi-govdata-archiving/web-monitoring-ops
that referenced
this pull request
Sep 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
diffTypesFor()function is intended to allow you to pass in a MediaType object, media type string, or a file extension (e.g.".pdf"). However, it turns out the file extension is broken (I guess we have pretty much stopped using file extensions since we improved media type support way back when...). This fixes the issue and adds a test.This bug was originally uncovered by @BeckettFrey in #1095. Thanks! 🙇