Support Promise variants of start and stop methods #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a verticle that overrides the
Verticle#start(Promise<Void)method, this module doesn't work correctly and fails to call start.This is because
GuiceVerticleLoaderhas no implementation of the promise method, which means execution falls to the default method in theVerticleinterface. This eventually leads to theGuiceVerticleLoaderattempting to call the real verticle's#start(Future<Void>method, rather than the Promise one.So added the
start(Promise<Void>)implementation toGuiceVerticleLoaderand created a new test for it.