Skip to content

Conversation

@jhwarner
Copy link

@jhwarner jhwarner commented Nov 2, 2019

When creating a verticle that overrides the Verticle#start(Promise<Void) method, this module doesn't work correctly and fails to call start.

This is because GuiceVerticleLoader has no implementation of the promise method, which means execution falls to the default method in the Verticle interface. This eventually leads to the GuiceVerticleLoader attempting to call the real verticle's #start(Future<Void> method, rather than the Promise one.

So added the start(Promise<Void>) implementation to GuiceVerticleLoader and created a new test for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants