Skip to content

Conversation

@chrisdennis
Copy link
Member

No description provided.

@chrisdennis chrisdennis requested a review from cljohnso October 12, 2022 19:57
AbfrmBlr
AbfrmBlr previously approved these changes Oct 13, 2022
@AbfrmBlr
Copy link
Contributor

This PR is daggy, want to merge in some other branch as well?

@chrisdennis chrisdennis marked this pull request as draft October 13, 2022 13:32
@chrisdennis
Copy link
Member Author

Pretty sure the merge in this is busted... I need to come back and look at it again later today.

@chrisdennis chrisdennis marked this pull request as ready for review December 14, 2022 23:07
@cljohnso
Copy link

The failed test, org.ehcache.clustered.replication.BasicClusteredCacheOpsReplicationMultiThreadedTest > testCRUD[consistency=EVENTUAL], appears to be a bit racy. It looks like it could use some additional coordination to ensure things actually get started before the ACTIVE is clobbered. May be some additional coordination needed between the "put" threads and the "get" thread. And are there enough executor threads to permit this test to run reliably -- 21 tasks vs 10 threads.

Definitely not related to your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants