Skip to content

Conversation

@t-persson
Copy link
Collaborator

@t-persson t-persson commented Nov 7, 2025

Applicable Issues

Keyservice is not deployed by default. Will be in #382

Description of the Change

Don't use apikeys unless we use SSE v2

Alternate Designs

I could remove the code, I just wanted to suggest this as an alternative

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Tobias Persson [email protected]

@t-persson t-persson requested a review from a team as a code owner November 7, 2025 11:25
@t-persson t-persson requested review from andmat900 and fredjn and removed request for a team November 7, 2025 11:25
@t-persson t-persson merged commit fc7c3c7 into eiffel-community:main Nov 10, 2025
3 checks passed
@t-persson t-persson deleted the dont-use-keyservice-if-it-is-not-deployed branch November 10, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants