Skip to content

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Sep 3, 2025

Proposed commit message

Relicense ETW reader to Apache

@marc-gr marc-gr added backport-skip Skip notification from the automated backport with mergify Team:Security-Windows Platform Windows Platform Team in Security Solution labels Sep 3, 2025
@marc-gr marc-gr requested a review from a team as a code owner September 3, 2025 07:30
@marc-gr marc-gr requested review from a team as code owners September 3, 2025 07:30
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 3, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@marc-gr marc-gr requested review from faec and khushijain21 September 3, 2025 07:30
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 3, 2025
Copy link
Contributor

github-actions bot commented Sep 3, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify mergify bot assigned marc-gr Sep 3, 2025
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Sep 3, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@marc-gr marc-gr requested a review from andrewkroh September 3, 2025 08:54
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just reviewed the BK changes and LGTM.

image

@cmacknz
Copy link
Member

cmacknz commented Sep 9, 2025

This looks fine to me, I just want to double check why we are doing this because this is a one way door kind of situation if this is the first time we moved this to Apache. I don't see any issue links for context.

@marc-gr
Copy link
Contributor Author

marc-gr commented Sep 12, 2025

This looks fine to me, I just want to double check why we are doing this because this is a one way door kind of situation if this is the first time we moved this to Apache. I don't see any issue links for context.

We need to use this code from an apache auditbeat module. SInce we have no specific reasons to have this in x-pack seems reasonable to move it so it can be used without hassle from apache-licensed code

@marc-gr marc-gr requested a review from cmacknz September 12, 2025 10:01
@marc-gr marc-gr merged commit 0c4a359 into elastic:main Sep 15, 2025
252 checks passed
@marc-gr marc-gr deleted the etw-to-apache branch September 15, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify libbeat:reader Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Security-Windows Platform Windows Platform Team in Security Solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants