-
Notifications
You must be signed in to change notification settings - Fork 5k
[libbeat] Move etw reader out of x-pack to Apache licensed code #46360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me, I just want to double check why we are doing this because this is a one way door kind of situation if this is the first time we moved this to Apache. I don't see any issue links for context. |
We need to use this code from an apache auditbeat module. SInce we have no specific reasons to have this in x-pack seems reasonable to move it so it can be used without hassle from apache-licensed code |
Proposed commit message
Relicense ETW reader to Apache