-
Notifications
You must be signed in to change notification settings - Fork 5k
libbeat: add 'eventfd2' to default seccomp policy #46372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libbeat: add 'eventfd2' to default seccomp policy #46372
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
911674b
to
d0078f2
Compare
44abf81
to
1892a43
Compare
1892a43
to
45371ed
Compare
45371ed
to
5f31562
Compare
Since Go introduced https://go.dev/cl/560615 it uses `eventfd2`, which was not part of our default seccomp policy. Due to the `google.golang.org/protobuf` dependency `eventfd2` during its initialisation, before our seccomp policy be applied, thus it worked. However once filebeat is reexeced, for example, due to a CA change, the seccomp policy would be in place and prevent `eventfd2` call, crashing filebeat. This change adds `eventfd2` to the default seccomp policy This also adjusts Beat.doReexec to use os.Executable isntead of manually building the binary path.
5f31562
to
de0ad4a
Compare
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
This pull request is now in conflicts. Could you fix it? 🙏
|
* libbeat: add 'eventfd2' to default seccomp policy Since Go introduced https://go.dev/cl/560615 it uses `eventfd2`, which was not part of our default seccomp policy. Due to the `google.golang.org/protobuf` dependency `eventfd2` during its initialisation, before our seccomp policy be applied, thus it worked. However once filebeat is reexeced, for example, due to a CA change, the seccomp policy would be in place and prevent `eventfd2` call, crashing filebeat. This change adds `eventfd2` to the default seccomp policy This also adjusts Beat.doReexec to use os.Executable isntead of manually building the binary path. (cherry picked from commit 7162773) # Conflicts: # libbeat/tests/integration/elasticsearch_test.go
* libbeat: add 'eventfd2' to default seccomp policy Since Go introduced https://go.dev/cl/560615 it uses `eventfd2`, which was not part of our default seccomp policy. Due to the `google.golang.org/protobuf` dependency `eventfd2` during its initialisation, before our seccomp policy be applied, thus it worked. However once filebeat is reexeced, for example, due to a CA change, the seccomp policy would be in place and prevent `eventfd2` call, crashing filebeat. This change adds `eventfd2` to the default seccomp policy This also adjusts Beat.doReexec to use os.Executable isntead of manually building the binary path. (cherry picked from commit 7162773) # Conflicts: # libbeat/tests/integration/elasticsearch_test.go
* libbeat: add 'eventfd2' to default seccomp policy Since Go introduced https://go.dev/cl/560615 it uses `eventfd2`, which was not part of our default seccomp policy. Due to the `google.golang.org/protobuf` dependency `eventfd2` during its initialisation, before our seccomp policy be applied, thus it worked. However once filebeat is reexeced, for example, due to a CA change, the seccomp policy would be in place and prevent `eventfd2` call, crashing filebeat. This change adds `eventfd2` to the default seccomp policy This also adjusts Beat.doReexec to use os.Executable isntead of manually building the binary path. (cherry picked from commit 7162773) # Conflicts: # libbeat/tests/integration/elasticsearch_test.go
* libbeat: add 'eventfd2' to default seccomp policy Since Go introduced https://go.dev/cl/560615 it uses `eventfd2`, which was not part of our default seccomp policy. Due to the `google.golang.org/protobuf` dependency `eventfd2` during its initialisation, before our seccomp policy be applied, thus it worked. However once filebeat is reexeced, for example, due to a CA change, the seccomp policy would be in place and prevent `eventfd2` call, crashing filebeat. This change adds `eventfd2` to the default seccomp policy This also adjusts Beat.doReexec to use os.Executable isntead of manually building the binary path. (cherry picked from commit 7162773) # Conflicts: # libbeat/tests/integration/elasticsearch_test.go
* libbeat: add 'eventfd2' to default seccomp policy Since Go introduced https://go.dev/cl/560615 it uses `eventfd2`, which was not part of our default seccomp policy. Due to the `google.golang.org/protobuf` dependency `eventfd2` during its initialisation, before our seccomp policy be applied, thus it worked. However once filebeat is reexeced, for example, due to a CA change, the seccomp policy would be in place and prevent `eventfd2` call, crashing filebeat. This change adds `eventfd2` to the default seccomp policy This also adjusts Beat.doReexec to use os.Executable isntead of manually building the binary path. (cherry picked from commit 7162773) # Conflicts: # libbeat/tests/integration/elasticsearch_test.go
…icy (#46450) * libbeat: add 'eventfd2' to default seccomp policy (#46372) Since Go introduced https://go.dev/cl/560615 it uses `eventfd2`, which was not part of our default seccomp policy. Due to the `google.golang.org/protobuf` dependency `eventfd2` during its initialisation, before our seccomp policy be applied, thus it worked. However once filebeat is reexeced, for example, due to a CA change, the seccomp policy would be in place and prevent `eventfd2` call, crashing filebeat. This change adds `eventfd2` to the default seccomp policy This also adjusts Beat.doReexec to use os.Executable isntead of manually building the binary path. (cherry picked from commit 7162773) # Conflicts: # libbeat/tests/integration/elasticsearch_test.go * fix merge conflicts --------- Co-authored-by: Anderson Queiroz <[email protected]>
…licy (#46448) * libbeat: add 'eventfd2' to default seccomp policy (#46372) Since Go introduced https://go.dev/cl/560615 it uses `eventfd2`, which was not part of our default seccomp policy. Due to the `google.golang.org/protobuf` dependency `eventfd2` during its initialisation, before our seccomp policy be applied, thus it worked. However once filebeat is reexeced, for example, due to a CA change, the seccomp policy would be in place and prevent `eventfd2` call, crashing filebeat. This change adds `eventfd2` to the default seccomp policy This also adjusts Beat.doReexec to use os.Executable isntead of manually building the binary path. (cherry picked from commit 7162773) # Conflicts: # libbeat/tests/integration/elasticsearch_test.go * fix merge conflicts --------- Co-authored-by: Anderson Queiroz <[email protected]>
…licy (#46447) * libbeat: add 'eventfd2' to default seccomp policy (#46372) Since Go introduced https://go.dev/cl/560615 it uses `eventfd2`, which was not part of our default seccomp policy. Due to the `google.golang.org/protobuf` dependency `eventfd2` during its initialisation, before our seccomp policy be applied, thus it worked. However once filebeat is reexeced, for example, due to a CA change, the seccomp policy would be in place and prevent `eventfd2` call, crashing filebeat. This change adds `eventfd2` to the default seccomp policy This also adjusts Beat.doReexec to use os.Executable isntead of manually building the binary path. (cherry picked from commit 7162773) # Conflicts: # libbeat/tests/integration/elasticsearch_test.go --------- Co-authored-by: Anderson Queiroz <[email protected]>
…icy (#46449) * libbeat: add 'eventfd2' to default seccomp policy (#46372) Since Go introduced https://go.dev/cl/560615 it uses `eventfd2`, which was not part of our default seccomp policy. Due to the `google.golang.org/protobuf` dependency `eventfd2` during its initialisation, before our seccomp policy be applied, thus it worked. However once filebeat is reexeced, for example, due to a CA change, the seccomp policy would be in place and prevent `eventfd2` call, crashing filebeat. This change adds `eventfd2` to the default seccomp policy This also adjusts Beat.doReexec to use os.Executable isntead of manually building the binary path. (cherry picked from commit 7162773) # Conflicts: # libbeat/tests/integration/elasticsearch_test.go * fix merge conflicts * add line break * fix linting issue --------- Co-authored-by: Anderson Queiroz <[email protected]>
I'll add the known issue in another PR as it affects other versions
Proposed commit message
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
How to test this PR locally
follow the steps outlined in the bug on how to reproduce the issue:
restart_on_cert_change
consistently causes crash #46333Related issues
restart_on_cert_change
consistently causes crash #46333Use cases